Showstoppers!

Rich

Leave a comment

Ok folks, list me off any bugs you find which are showstoppers!

If there are no showstoppers, then I suggest we push the site live and I'll fix the other remaining bugs on the fly.

-Rich

Testing Testing Testing

Rich

8 comments

Leave a comment

Ok guys, I need you to test like crazy. I've just pushed some changes which should make the site work properly in IE6 (Or as I call it, IE-Shit).

Everything user-facing should be ready to go live. The idea being that you can put up the site, and then any future additions (priv packages, admin stats, email notifs, etc) can be done whenever as it doesn't really effect users being able to view the site.

So if you could test everything, and report anything that you don't like or that you want changing. CSS, images, whatever. In the meantime, I'll work on neatening up the code, just from a purely OCD perspective :)

As before, if you find any bugs, add them to a list in this blog entry

===================================
CURRENT BUGS

01. [FIXED - My bad, had typo in the variable] - 12/12/08 - Page title not filled in when going to release pages, http://fs.wblinks.com/music/SK123/Another+Release, check the page title field, seems to only be on album releases.

02. [FIXED - Artist vibes weren't going through sanitizer] - 01/01/09 - On Vibes, the email address validation works fine, however under the email address you entered is not valid" error when asked to re-input, it's apparent that the field isn't being stripped of HTML characters. E.g. enter " LOL" and you will get " LOL" [note the space character] when asked to re-enter. I tried some JavaScript tags and received an XML parsing error. Could this lead to trouble if manipulated by someone who actually knows what they're talking about? The 'Name' field is susceptible to this too, however the 'Vibe' field is not.

03. [FIXED - Added a vibeForm link, so it'll automatically go to the form after submitting. If it was successful, there is no form, so it won't change.] - 01/01/09 - If there are a lot of Vibes comments on the page and the user unsuccessfully submits a comment, the "please try again" resulting page may be too long, preventing the user from noticing the error at the bottom of the page. Could we use something like an tag to automatically guide the user back to the bottom of the Vibes column upon unsuccessful submission?

04. [FIXED - Whoa, yeah.. this was some pretty messed up DB corruption because I wasn't deleting some links when deleting an Artist/Release. Should now all work fine.] - 01/01/09 - Following the deletion of a test SK123 album and a test Macadamia album, the pages for these artists' releases (Skizm/Soundspill) now display a parsing error:

XML Parsing Error: unclosed token

Location: http://fs.wblinks.com/music/Macadamia/Soundspill

Line Number 91, Column 66: < h3 class="releaseTitle" >< a href="/music/Unable to execute query: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1DEBUG : SELECT `artist_id` FROM `fs_artist_release` WHERE `release_id`= It's important to note that Colin Close had no releases removed, and their EP release page works fine.

05. [FIXED - Same as above. It deleted the release, but not the link from artist->release, so it was still in the count.] - 01/01/09 - With regards to issue #4 (above): following the deletion of these albums, on the Music page each artist still has "2 Releases".

06. [FIXED - Simple CSS fix, no worries.] - 14/12/08 - Would it be possible to reduce the height of the New Releases bar on the main page (and the images within)? The current bar takes too much away from the news column below; this is especially evident on screen resolutions of 1024*768 or less, where the news isn't even on the screen. A screenshot may be found here (only a rough idea, displaying 3 releases - more than 3 would be preferable on the screen at this size).

07. [FIXED - taget="_blank" is no longer valid in XHTML, so used some fancy JavaScript to sort this out.] - 12/12/08 - Could we please have the LastFM links (etc) on an artist's/release's page opening in a new window?

08. [FIXED - FSML parsing error. There was a bug in my regexp.] - 12/12/08 - See previous comment, point #06: entering the code "[ url:http://msghamer.net/fs/fs_newmain.PNG ]here[ /url ]" does not load the web address provided.

09. [submitted - No worries, will get on it.] - 10/12/08 - May we please have the ability to edit comments? This is low priority.

10. [ALMOST - I've almost done this, just need to get it to parse the FSML properly, sometimes it cuts off before the end of a HTML tag] - 12/12/08 -
Go here: http://fs.wblinks.com/search?search=H - it's a search page for the phrase "H". Currently, the latest vibe comment for each search result is visible next to the artist/release. Can we change this to the first part of the artist description, with a trailing "..." if the text is too long for the row?

11. [FIXED - I wasn't checking if the vibes array was null before trying to iterate over them and delete them. Rookie mistake, my bad.] - 10/01/09 - After deleting the SK123/'Skizm' release, the following error occurred:

XML Parsing Error: junk after document element
Location: http://fs.wblinks.com/admin/admin_release.php
Line Number 2, Column 1:< b >Warning< /b >: Invalid argument supplied for foreach() in < b >/home/.major/wblinks/fs.wblinks.com/classes/Release.class.php< /b > on line < b >195< /b >
^

- Update: same goes for when deleting the artist SK123.

12. [FIXED - Hadn't updated rss feeds to use correct site_config variable when I changed it ages ago] - 10/01/09 - Clicking the News feed throws an error.

13. [UNKOWN - I'm afraid I've no idea what would cause this. Are you sure it's the 404 page? and not just another page that hasn't loaded the content properly? ] - 10/01/09 - Occasionally (I don't have any examples) the site will not throw a 404 error ('Sorry, the page you are looking for could not be found. Perhaps you'd like to take a look at some of the items below instead.'). Instead there is just a blank mid-section in the page between the usual page header and footer. Rich - if you can't figure out what this may be off the top of your head don't worry about it, we'll report it when we find a specific instance.

14. [FIXED - Yeah, that should be bad_login.. it's because I'm on the baggage team at work.. so I tend to type bag more than any other word :). It wasn't being used because of the wrong name. I've renamed it to bad_login so it will now show up when you get the wrong details.] - 10/01/09 - In Site Text, 'bag_login' (should this be 'bad_login'?) doesn't seem to be used; upon unsuccessful login, the login page reloads without any additional text. Would it be possible/necessary to build in the site text to indicate the failed login?

15a. [FIXED] - 10/01/09 - Could we please have "New Releases" on the main page changed to "New & Upcoming Releases"?

15b. [FIXED] - 10/01/09 - Could we please have the New & Upcoming Releases section contain a wider spacing for the releases, so as to create a wider/tidier margin between new releases? 3 releases is probably the best setting for this panel, and we probably won't need more than 3, if this helps!

16. [INVALID - The release tag MUST be followed by an artist tag. Two artists could have the same release name, so you need to specify the correct artist. There also doesn't need to be a closing tag, it's just one tag and it will automatically put the correct name in. See the "FSML Help" bit at the bottom page where you type the info in.] - 10/01/09 - Go here: http://fs.wblinks.com/music/Colin%20Close. The [ release: ] tag is not working. I'm expecting this to be my fault - am I doing something wrong here?

17. [FIXED] - 10/01/09 - On the Release pages, can we please have the text "Released on" text changed to "Release date"? This will help when introducing the "...& Upcoming Releases" to the New Releases section. Thanks!

18. [submitted] - 10/01/09 - On the admin pages when admining a release, the date boxes are a little squashed when viewed on Apple Safari, but in Firefox. This a very minor issue and should not be prioritised :)

19. [FIXED - This was due to the referer not including the GET parameters when passing through the login/logout script. So it was going back to the releases page, but without an artist/release name being passed in.] - 10/01/09 - We get a 404 after logging in, navigating to the CC EP release, and logging out. No error message is given except for "Not found" in the page title. Here's a screenshot: http://msghamer.net/fs/notfound.PNG.

20. [submitted] - 10/01/09 - I have no idea why, but on Firefox on my parents' laptop (latest version), the Vibes comments fields are screwed up and exceed the width of the page. I've seen this before but I don't remember on which machine. Please see http://msghamer.net/fs/BadVibes.jpg. If you can't find anything for this we can maybe blame it on a dodgy FF plugin or something - it works fine on my Firefox and even on IE8!

testing

Google Chrome

Rich

1 comment

Leave a comment

Just FYI. Site looks fine in Chrome. Just IE that I need to fix for really. God I hate IE.

More bug fixes coming this weekend.

Definitive Bug List/Feature Request

Jan

13 comments

Leave a comment

I thought I'd create a definitive list of bugs.

It is going to take me some time to work through the list on this page, and I'm not quite sure sometimes which ones have been fixed, but here goes ... Can everyone else also contribute to this list.

If you have posted a bug report somewhere else, can you please add it to this list as well please. Cheers. Read More...

bugs, bug, feature, features, request

Bugs

Rich

3 comments

Leave a comment

Anyone got any bugs they've found? or any bugs you've already reported that I've missed?

Things I've fixed recently :
- Search page would swap to music search rather than news search when using spelling suggestions.
- Same as above, but for the 'search again' box too.
- Releases admin page wasn't using correct instance of the Sanitizer, and was not handling quotes correctly. So if a release had a quote in it, it would come out as "Rich's Test Release".
- One of the params on the search page wasn't being passed through the sanitizer.
- Modified DBObject class to handle null objects silently without causing complete page error.
- Fixed news page so that if you attempt to pass in bad ID it won't crap out.
- Quotes in Release title weren't HTML encoded properly, so the URL fucked up.
- Bug in admin page meant that if it craps out while creating a new release, it wasn't rolling back the changes, so the DB had inconsistent data.

bugs, bug fixes, release